[core] fix(EditableText): optimize updateInputDimensions #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SatishGandham thanks for taking my suggestion and running with it. Looks like it is an incomplete implementation and will need to be adjusted / tweaked to get the right behavior. There are a few problems with this approach right now. (1) The input is not expanding its height past its minLines to accommodate longer text:
(2) When switching to
|
2 tasks
…s, so call updateInputDimensions when either change.
|
@adidahiya, Made the necessary changes. |
adidahiya
approved these changes
May 19, 2021
adidahiya
changed the title
|
thanks @SatishGandham! |
|
Thank you @SatishGandham 🙌 Never got time to finish the implementation in #4639 myself. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
componentDidUpdateof Editable text callsupdateInputDimensionson every rerender, this triggers the layout calculations.This PR addresses that issue by only calling
updateInputDimensionsonly when the props it depends on changeref: #4639 (comment)
Reviewers should focus on:
Confirm if calling
updateInputDimensionsconditionally is a safe change